Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support
From: Darren Hart <hidden>
Date: 2013-07-13 05:53:06
Also in:
lkml, stable
On Fri, 2013-07-12 at 18:10 -0700, Joe Perches wrote:
On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote:quoted
The MinnowBoard uses an AR803x PHY with the PCH GBE which requires special handling. Use the MinnowBoard PCI Subsystem ID to detect this and add a pci_device_id.driver_data structure and functions to handle platform setup.trivial comments only: Please use scripts/checkpatch.pl
Always good advice. I did actually do that. Some of the reports conflict with existing formatting throughout the file. I opted for consistency. The others.... sigh, I did a last minute cleanup and somehow introduced the whitespace errors. I do know better and should have waited until tonight instead of sending them out when I was rushed. Apologies. Fixed in V3 and awaiting additional feedback.
quoted hunk ↗ jump to hunk
[]diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c[][]quoted
+static int pch_gbe_minnow_platform_init(struct pci_dev *pdev)[]quoted
+ if (ret){Missing space before brace
Fixed.
quoted
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c[]quoted
+int pch_gbe_phy_tx_clk_delay(struct pch_gbe_hw *hw)[]quoted
+ case PHY_AR803X_ID: + netdev_dbg(adapter->netdev, + "Configuring AR803X PHY for 2ns TX clock delay\n");[]quoted
+ netdev_err(adapter->netdev, + "Unknown PHY (%x), could not set TX clock delay.\n", + hw->phy.id);[]quoted
+ netdev_err(adapter->netdev, + "Could not configure tx clock delay for PHY.\n");[]quoted
+int pch_gbe_phy_disable_hibernate(struct pch_gbe_hw *hw)[]quoted
+ case PHY_AR803X_ID: + netdev_dbg(adapter->netdev, + "Disabling hibernation for AR803X PHY\n");It'd be nice if no period before newline were used everywhere.
Indeed, fixed. Thank you for the review.
quoted
+ netdev_err(adapter->netdev, + "Unknown PHY (%x), could not disable hibernation\n", + hw->phy.id);[]quoted
+ netdev_err(adapter->netdev, + "Could not disable PHY hibernation.\n");
-- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel