Thread (12 messages) flat view 12 messages, 6 authors, 2013-07-10

Re: [PATCH 0/2] virtio_net: fix race in RX VQ processing

From: David Miller <davem@davemloft.net>
Date: 2013-07-09 03:54:57
Also in: lkml

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Mon, 8 Jul 2013 12:05:26 +0300
Jason Wang reported a race in RX VQ processing:
virtqueue_enable_cb is called outside napi lock,
violating virtio serialization rules.
The race has been there from day 1, but it got especially nasty in 3.0
when commit a5c262c5fd83ece01bd649fb08416c501d4c59d7
"virtio_ring: support event idx feature"
added more dependency on vq state.

Please review, and consider for 3.11 and for stable.

Jason, could you please report whether this fixes the issues for you?
Please resubmit with the minor coding style fix and Jason's Acked-by/Tested-by

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help