Thread (10 messages) 10 messages, 3 authors, 2013-07-31

RE: [PATCH net-next 1/6] qlcnic: Add ethtool statistics for board temperature.

From: Himanshu Madhani <hidden>
Date: 2013-07-31 18:09:04

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Tuesday, July 30, 2013 7:27 PM
To: Himanshu Madhani
Cc: netdev; Dept-NX Linux NIC Driver
Subject: Re: [PATCH net-next 1/6] qlcnic: Add ethtool statistics for board
temperature.

From: Himanshu Madhani <redacted>
Date: Tue, 30 Jul 2013 21:54:19 -0400
quoted
From: Himanshu Madhani <redacted>

o Added ethtool statistics to display adapter board
  temperature.

Signed-off-by: Himanshu Madhani <redacted>
A statistic is a count of events, this is not such a thing.

Furthermore, even if this fit the model of statistical events, there is no way
for the user to know what units the value is in.

Sorry I'm not applying these patches.
I am dropping this patch from this series and will implement HWMON API for sensing temperature.

I am resubmitting rest of the patches in this series which are unrelated to the above patch.

Thanks, 
-Himanshu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help