Thread (7 messages) 7 messages, 3 authors, 2013-08-02

Re: [PATCH 1/2] igb: Add macro for size of RETA indirection table

From: Jeff Kirsher <hidden>
Date: 2013-07-31 09:14:57

On Wed, 2013-07-31 at 11:43 +0300, Laura Mihaela Vasilescu wrote:
Signed-off-by: Laura Mihaela Vasilescu <redacted>
---
 drivers/net/ethernet/intel/igb/igb.h      |    2 ++
 drivers/net/ethernet/intel/igb/igb_main.c |    2 +-
 2 files changed, 3 insertions(+), 1 deletion(-) 
Not sure if I mentioned it in your first submission, if I did not then
my bad. The title of your patch is descriptive of the changes, but it is
always nice to have a detailed patch description.  I noticed your second
patch is similar to the first, in that it does not have a detailed patch
description.

Information that would be good to include in the patch description is:
- why the change or reason for the change
- advantages/disadvantages to the change

Laura please re-submit your two patches with a detailed/meaningful patch
description to at least the second patch (but both would be great).

Think of it this way, if someone were to look at your changes 10 years
from now and did not understand why the change, your patch description
would explain all.

Cheers,
Jeff

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help