Re: [PATCH net 2/6] bnx2x: prevent statistics update flow to act before statistics are started
flat view
From: Sergei Shtylyov <hidden>
Date: 2013-07-16 18:14:33
Hello. On 07/16/2013 07:21 PM, Dmitry Kravkov wrote:
This in order to serialize statistics requests sent to FW, otherwise two outstanding queries may cause FW assert.
Signed-off-by: Dmitry Kravkov <redacted> Signed-off-by: Ariel Elior <redacted> Signed-off-by: Eilon Greenstein <redacted> --- drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 1 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c | 6 +++++- 3 files changed, 7 insertions(+), 1 deletion(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h index dedbd76..bdbd87e 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h@@ -1830,6 +1830,7 @@ struct bnx2x { int fp_array_size; u32 dump_preset_idx; + atomic_t stats_started;
Why it's so wildly indented if its neighbors are not?
}; /* Tx queues may be less or equal to Rx queues */
WBR, Sergei