Re: [PATCH] net: Swap ver and type in pppoe_hdr
From: David Miller <davem@davemloft.net>
Date: 2013-07-02 01:20:21
From: David Miller <davem@davemloft.net>
Date: 2013-07-02 01:20:21
From: Changli Gao <redacted> Date: Sat, 29 Jun 2013 00:15:51 +0800
Ver and type in pppoe_hdr should be swapped as defined by RFC2516 section-4.
I can't believe this has been wrong for more than 8 years.
But, of course, it is possible. Especially since we never check these
'ver' and 'type' fields on packet input, and we always set them both
to the same value ('1') on output.
Applied, thanks.