Thread (5 messages) 5 messages, 4 authors, 2013-07-01

Re: [PATCH v3] iwl3945: better skb management in rx path

From: Stanislaw Gruszka <hidden>
Date: 2013-07-01 12:13:24
Also in: linux-wireless

On Fri, Jun 28, 2013 at 08:05:06AM -0700, Eric Dumazet wrote:
From: Eric Dumazet <edumazet@google.com>

Steinar reported reallocations of skb->head with IPv6, leading to
a warning in skb_try_coalesce()

It turns out iwl3945 has several problems :

1) skb->truesize is underestimated. 
   We really consume PAGE_SIZE bytes for a fragment,
   not the frame length.
2) 128 bytes of initial headroom is a bit low and forces reallocations.
3) We can avoid consuming a full page for small enough frames.

Reported-by: Steinar H. Gunderson <redacted>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Paul Stewart <redacted>
Acked-by: Stanislaw Gruszka <redacted>

FYI, I'll post 4965 version soon.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help