Thread (1 message) 1 message, 1 author, 2013-06-20

Re: [PATCH] trace: using strlcpy instead of strncpy

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2013-06-20 12:20:06
Also in: lkml

This fix is to a networking tracepoint. It should go through the
networking folks.

-- Steve


On Thu, 2013-06-20 at 19:07 +0800, Zhao Hongjiang wrote:
quoted hunk
for NUL terminated string, need alway set '\0' in the end.

Signed-off-by: Zhao Hongjiang <redacted>
---
 include/trace/events/sock.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/trace/events/sock.h b/include/trace/events/sock.h
index 779abb9..333d8b5 100644
--- a/include/trace/events/sock.h
+++ b/include/trace/events/sock.h
@@ -44,7 +44,7 @@ TRACE_EVENT(sock_exceed_buf_limit,
 	),
 
 	TP_fast_assign(
-		strncpy(__entry->name, prot->name, 32);
+		strlcpy(__entry->name, prot->name, 32);
 		__entry->sysctl_mem = prot->sysctl_mem;
 		__entry->allocated = allocated;
 		__entry->sysctl_rmem = prot->sysctl_rmem[0];
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help