Thread (7 messages) flat view 7 messages, 3 authors, 2013-11-11

Re: [PATCH] net bridge: add null pointer check, fix panic

From: Eric Dumazet <hidden>
Date: 2013-06-20 04:55:35
Also in: bridge, lkml

Possibly related (same subject, not in this thread)

On Thu, 2013-06-20 at 11:08 +0800, xiaoming gao wrote:
From: newtongao <redacted>
Date: Wed, 19 Jun 2013 14:58:33 +0800
Subject: [PATCH] net bridge: add null pointer check,fix panic

in kernel 3.0, br_port_get_rcu() may return NULL when network interface be deleting from bridge,
but in function br_handle_frame and br_handle_local_finish, the pointer didn't be checked before using,
so all br_port_get_rcu callers must do null check,or there occurs the null pointer panic.

kernel 3.4 also has this bug,i have verified.
mainline kernel still did not  check br_port_get_rcu()'s NULL pointer, but i have not tested it yet.
Please check current version before sending a patch.

This was most probably fixed in commit 00cfec37484761a44
("net: add a synchronize_net() in netdev_rx_handler_unregister()")

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help