Re: [PATCH v4] ethernet/arc/arc_emac - Add new driver
From: Joe Perches <joe@perches.com>
Date: 2013-06-15 20:37:53
Also in:
linux-devicetree, lkml
On Sun, 2013-06-16 at 00:20 +0400, Alexey Brodkin wrote:
Driver for non-standard on-chip ethernet device ARC EMAC 10/100, instantiated in some legacy ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
[]
+ if (DUPLEX_FULL == phy_dev->duplex)
Most all kernel code uses "if (var == constant)" as that's how most people think. []
+static int arc_emac_rx(struct net_device *ndev, int budget)
[]
+ /* Prepare the BD for next cycle */
+ rx_buff->skb = netdev_alloc_skb_ip_align(ndev, buflen);
+ if (unlikely(!rx_buff->skb)) {
+ if (net_ratelimit())
+ netdev_err(ndev, "cannot allocate skb\n");Unnecessary OOM message, might as well remove it. rx_dropped gives the same info.