Thread (17 messages) 17 messages, 5 authors, 2013-06-05

Re: [PATCH v3] include/linux/skbuff.h: using '(__u16) ~0U' instead of '~0U'

From: David Miller <davem@davemloft.net>
Date: 2013-06-05 08:36:07
Also in: lkml

From: Chen Gang <redacted>
Date: Wed, 05 Jun 2013 08:54:22 +0800
Both 'transport_header' and 'mac_header' are __u16, which are
never equal to '~0U'.

So need use '(__u16) ~0U' instead of '~0U'.

The related warning (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
  include/linux/skbuff.h:1587:2: warning: comparison is always true due to limited range of data type [-Wtype-limits]
  ...

Use meaningful macro instead of hard code number, and better to
initialize 'skb->transport_header' in __alloc_skb_head(), too.



Signed-off-by: Chen Gang <redacted>
Your patch doesn't apply to the tree because this has been fixed already
for several days by using "typeof(x) ~0U"
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help