Re: [PATCH 8/8] alx: remove WoL support
From: Johannes Stezenbach <hidden>
Date: 2013-06-29 19:13:52
On Sat, Jun 29, 2013 at 07:23:20PM +0200, Johannes Berg wrote:
Unfortunately, WoL is broken and the system will immediately resume after suspending, and I can't seem to figure out why. Remove WoL support until the issue can be found.
...
quoted hunk ↗ jump to hunk
-#ifdef CONFIG_PM_SLEEP -static SIMPLE_DEV_PM_OPS(alx_pm_ops, alx_suspend, alx_resume); -#define ALX_PM_OPS (&alx_pm_ops) -#else -#define ALX_PM_OPS NULL -#endif - static DEFINE_PCI_DEVICE_TABLE(alx_pci_tbl) = { { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8161), .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG },@@ -1614,9 +1472,7 @@ static struct pci_driver alx_driver = { .id_table = alx_pci_tbl, .probe = alx_probe, .remove = alx_remove, - .shutdown = alx_shutdown, .err_handler = &alx_err_handlers, - .driver.pm = ALX_PM_OPS, };
Not sure but doesn't that mean the driver breaks after suspend? I think you removed too much, not just WOL support but all pm handling. Johannes