Re: [Patch net-next v2] ipv6,mcast: always hold idev->lock before mca_lock
From: Hannes Frederic Sowa <hidden>
Date: 2013-06-29 13:53:22
On Sat, Jun 29, 2013 at 09:30:49PM +0800, Cong Wang wrote:
quoted hunk ↗ jump to hunk
--- a/include/net/addrconf.h +++ b/include/net/addrconf.h@@ -86,6 +86,9 @@ extern int ipv6_dev_get_saddr(struct net *net, const struct in6_addr *daddr, unsigned int srcprefs, struct in6_addr *saddr); +extern int __ipv6_get_lladdr(struct inet6_dev *idev, + struct in6_addr *addr, + unsigned char banned_flags); extern int ipv6_get_lladdr(struct net_device *dev, struct in6_addr *addr, unsigned char banned_flags);diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 4e4cc1f..611b5cc 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c@@ -1444,8 +1444,8 @@ try_nextdev: } EXPORT_SYMBOL(ipv6_dev_get_saddr); -static int __ipv6_get_lladdr(struct inet6_dev *idev, struct in6_addr *addr, - unsigned char banned_flags) +int __ipv6_get_lladdr(struct inet6_dev *idev, struct in6_addr *addr, + unsigned char banned_flags) { struct inet6_ifaddr *ifp; int err = -EADDRNOTAVAIL;diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index 72c8bfe..dd0de91 100644
If we export __ipv6_get_lladdr in a header, shouldn't we also EXPORT_SYMBOL it? I am not sure but would have done so. Thanks, Hannes