RE: [PATCH RFC net-next v1 1/1] net: fec: Fix RMON registers on imx6
From: Duan Fugang-B38611 <hidden>
Date: 2013-06-29 05:58:49
Possibly related (same subject, not in this thread)
- 2013-07-01 · Re: [PATCH RFC net-next v1 1/1] net: fec: Fix RMON registers on imx6 · Jim Baxter <hidden>
On 06/28/13 23:08, Jim Baxter wrote:
quoted hunk ↗ jump to hunk
commit 38ae92d "fec: Add support for reading RMON registers" causes the imx6Q to crash. This fixes it and clears it using the MIB Control Register's MIB_CLEAR bit. Signed-off-by: Jim Baxter <redacted> --- drivers/net/ethernet/freescale/fec_main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index ed6180e..a1f0413 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c@@ -607,8 +607,12 @@ fec_restart(struct net_device *ndev, int duplex) #ifndef CONFIG_M5272 /* Disable, clear, and enable the MIB */ writel(1 << 31, fep->hwp + FEC_MIB_CTRLSTAT); - for (i = RMON_T_DROP; i < IEEE_R_OCTETS_OK; i++) - writel(0, fep->hwp + i); + if (strcmp(id_entry->name, "imx6q-fec") == 0) { + writel(1 << 29, fep->hwp + FEC_MIB_CTRLSTAT); + } else { + for (i = RMON_T_DROP; i < IEEE_R_OCTETS_OK; i++) + writel(0, fep->hwp + i); + } writel(0, fep->hwp + FEC_MIB_CTRLSTAT); #endif --1.7.10.4
It is not necessary to clear MIB since fec_restart() will reset MAC which cause all MAC register auto reset to zero. Thanks, Andy