Re: [PATCH net-next v2 2/2] net: sctp: rework debugging framework to use pr_debug and friends
From: Joe Perches <joe@perches.com>
Date: 2013-06-27 14:49:55
Also in:
linux-sctp
On Thu, 2013-06-27 at 11:43 +0200, Daniel Borkmann wrote:
- Changed %pIg into %pIS, thanks Joe Perches
Hi Daniel.
quoted hunk ↗ jump to hunk
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
[]
+ pr_debug("%s: association:%p addr:%pIS port:%d\n",
+ __func__, asoc, &peer->ipaddr.sa,
+ ntohs(peer->ipaddr.v4.sin_port));This is why I think %pIS should have an option to print port/flow, etc. In this case it's using v4 and you are mixing unknown and known forms. It looks untidy. You should probably use peer->sa.sin_port instead.
quoted hunk ↗ jump to hunk
@@ -636,12 +638,8 @@ struct sctp_transport *sctp_assoc_add_peer(struct sctp_association *asoc, /* AF_INET and AF_INET6 share common port field. */ port = ntohs(addr->v4.sin_port); - SCTP_DEBUG_PRINTK_IPADDR("sctp_assoc_add_peer:association %p addr: ", - " port: %d state:%d\n", - asoc, - addr, - port, - peer_state); + pr_debug("%s: association:%p addr:%pIS port:%d state:%d\n", __func__, + asoc, &addr->sa,port , peer_state);
here too, but port may be unused when !CONFIG_DEBUG I didn't look at the rest of the patch.