Re: [PATCH net-next v5 5/6] rtnetlink: allow using zero MAC address in rtnl_fdb_{add,del}
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2013-06-25 16:37:42
Subsystem:
ethernet bridge, networking [general], the rest · Maintainers:
Nikolay Aleksandrov, Ido Schimmel, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
This is needed, to avoid breaking bridge use of fdb. I will just add it after Mike's patches.
From 9d1cdde78c5973eeb0c80b5b053ea35e61005253 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen@networkplumber.org> Date: Tue, 25 Jun 2013 09:34:36 -0700 Subject: [PATCH] bridge: check for zero ether address in fdb add The check for all-zero ether address was removed from rtnetlink core, since Vxlan uses all-zero ether address to signify default address. Need to add check back in for bridge. Signed-off-by: Stephen Hemminber <stephen@networkplumber.org> --- net/bridge/br_fdb.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index ebfa444..60aca91 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c@@ -707,6 +707,11 @@ int br_fdb_add(struct ndmsg *ndm, struct nlattr *tb[], } } + if (is_zero_ether_addr(addr)) { + pr_info("bridge: RTM_NEWNEIGH with invalid ether address\n"); + return -EINVAL; + } + p = br_port_get_rtnl(dev); if (p == NULL) { pr_info("bridge: RTM_NEWNEIGH %s not a bridge port\n",
--
1.7.10.4