Thread (19 messages) 19 messages, 4 authors, 2013-06-24

Re: [PATCH net-next v4 1/2] vxlan: introduce vxlan_rdst_append

From: David Miller <davem@davemloft.net>
Date: 2013-06-24 08:29:03

From: Mike Rapoport <redacted>
Date: Mon, 24 Jun 2013 09:54:51 +0300
On Mon, Jun 24, 2013 at 9:02 AM, Cong Wang [off-list ref] wrote:
quoted
On Sun, 23 Jun 2013 at 16:22 GMT, Mike Rapoport [off-list ref] wrote:
quoted
to allow remotes list management for both FDB entries and default
destinations

Signed-off-by: Mike Rapoport <redacted>
---
 drivers/net/vxlan.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 212a256..e5fb6568 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -386,14 +386,13 @@ static struct vxlan_fdb *vxlan_find_mac(struct vxlan_dev *vxlan,
      return f;
 }

-/* Add/update destinations for multicast */
-static int vxlan_fdb_append(struct vxlan_fdb *f,
+static int vxlan_rdst_append(struct list_head *remotes,
                          __be32 ip, __be16 port, __u32 vni, __u32 ifindex)

I think you need to align the above line.
I just kept the original indentation
When you change the arguments to a function, you are absolutely obligated
to fix the indentation of any surrounding lines.

In the networking code, functions are to be styled such that the arguments
appearing on the second and subsequent lines are aligned perfectly to the
first column after the openning parenthesis of the first line.

Therefore, if you change where that openning parenthesis is, you must
reindent the subsequent lines.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help