Re: [PATCH v2] ipv6: fix ecmp lookup when oif is specified
From: David Miller <davem@davemloft.net>
Date: 2013-06-24 01:40:19
From: David Miller <davem@davemloft.net>
Date: 2013-06-24 01:40:19
From: Nicolas Dichtel <redacted> Date: Fri, 14 Jun 2013 10:32:58 +0200
There is no reason to skip ECMP lookup when oif is specified, but this implies to check oif given by user when selecting another route. When the new route does not match oif requirement, we simply keep the initial one. Spotted-by: dingzhi [off-list ref] Signed-off-by: Nicolas Dichtel <redacted>
IPV4 routing has elided the multipath lookup when the interface is specified for nearly two decades. So two things: 1) A decision that old must have a good reason, and you must do some research to figure out exactly what that reason is. 2) If ipv4 is found to be wrong too, we must bring both ipv4 and ipv6 into the same behavior at the same time. But I do not want to make this change for another reason, it potentially breaks things for someone, somewhere. And I see very miniscule, if any, value to this new behavior. The risk far outweighs the gains. Sorry, I really have to reject this patch for now.