Re: [PATCH iproute2] htb: report overhead attribute
From: Rick Jones <hidden>
Date: 2013-06-03 15:45:09
On 06/02/2013 02:33 PM, Eric Dumazet wrote:
quoted hunk ↗ jump to hunk
From: Eric Dumazet <edumazet@google.com> "tc class show dev ..." omits the overhead attribute for HTB. After patch I have : tc class add dev $DEV parent 1: classid 1:1 est 1sec 4sec htb \ rate 12Mbit mtu 1500 quantum 1514 overhead 20 tc class show dev $DEV class htb 1:1 root prio 0 rate 12000Kbit overhead 20 ceil 12000Kbit burst 1500b cburst 1500b Signed-off-by: Eric Dumazet <edumazet@google.com> --- tc/q_htb.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/tc/q_htb.c b/tc/q_htb.c index caa47c2..e6b09bb 100644 --- a/tc/q_htb.c +++ b/tc/q_htb.c@@ -264,6 +264,8 @@ static int htb_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) fprintf(f, "quantum %d ", (int)hopt->quantum); } fprintf(f, "rate %s ", sprint_rate(hopt->rate.rate, b1)); + if (hopt->rate.overhead) + fprintf(f, "overhead %u ", hopt->rate.overhead);
Is it (still) possible to have a negative overhead? http://www.linksysinfo.org/index.php?threads/speedmod-with-tc-atm-qos-patch-for-adsl.31541/ rick jones