Re: [PATCH net-next v3] netfilter: Correct calculation using skb->tail and skb-network_header
From: Chen Gang <hidden>
Date: 2013-06-03 09:06:53
Also in:
netfilter-devel
From: Chen Gang <hidden>
Date: 2013-06-03 09:06:53
Also in:
netfilter-devel
On 05/31/2013 10:39 AM, Simon Horman wrote:
This corrects an regression introduced by "net: Use 16bits for *_headers fields of struct skbuff" when NET_SKBUFF_DATA_USES_OFFSET is not set. In that case skb->tail will be a pointer whereas skb->network_header will be an offset from head. This is corrected by using wrappers that ensure that calculations are always made using pointers. Reported-by: Stephen Rothwell <redacted> Reported-by: Chen Gang <redacted> Signed-off-by: Simon Horman <horms@verge.net.au> -- v3 * Add net-next to subject prefix v2 * Use skb_tail_pointer() to ensure the tail portion of the calculation is always a pointer - it is not if NET_SKBUFF_DATA_USES_OFFSET is not set.
Thanks. -- Chen Gang Asianux Corporation