Re: [PATCH v3] Bluetooth: hidp: using strlcpy instead of strncpy, also beautify code.

On 05/21/2013 05:52 AM, Gustavo Padovan wrote:

Hi Chen,

* Chen Gang [off-list ref] [2013-05-13 10:07:11 +0800]:

quoted

quoted

For NUL terminated string, need always let it ended by zero.

Since have already called memcpy() to initialize 'ci', so need not
redundant initialization.

Better use ''if(session->hid) {} else if(session->input) {}"" instead
of ''if(session->hid) {}; if(session->input) {};''

Signed-off-by: Chen Gang <redacted>
---
 net/bluetooth/hidp/core.c |   14 ++++----------
 1 files changed, 4 insertions(+), 10 deletions(-)

Sorry for the big delay on this, patches has now been applied to
bluetooth-next. Thanks all.

It doesn't matter, every member have their own work, especially, most of
us are busy.

Thank you for your work, too.


Thanks.
-- 
Chen Gang

Asianux Corporation