Re: [PATCH v5 12/13] ARM: kirkwood: remove redundant DT board files
From: Arnaud Ebalard <hidden>
Date: 2013-05-30 09:16:01
Also in:
linux-arm-kernel, linuxppc-dev, lkml
Hi Jason and Sebastian, Sebastian Hesselbarth [off-list ref] writes:
With DT support for mv643xx_eth board specific init for some boards now is unneccessary. Remove those board files, Kconfig entries, and corresponding entries in kirkwood_defconfig. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> --- Note: board-km_kirkwood.c is also removed, as Valentin Longchamp confirmed the lock-up is not caused by accessing clock gating registers but rather non-existent device registers. This will be addressed by dtsi separation for kirkwood and bobcat SoC variants. Changelog: v3->v4: - remove more boards that don't require board specific setup Cc: David Miller <davem@davemloft.net> Cc: Lennert Buytenhek <redacted> Cc: Jason Cooper <redacted> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org --- arch/arm/configs/kirkwood_defconfig | 16 ---- arch/arm/mach-kirkwood/Kconfig | 117 ------------------------- arch/arm/mach-kirkwood/Makefile | 16 ---- arch/arm/mach-kirkwood/board-dnskw.c | 7 -- arch/arm/mach-kirkwood/board-dockstar.c | 32 ------- arch/arm/mach-kirkwood/board-dreamplug.c | 35 -------- arch/arm/mach-kirkwood/board-dt.c | 62 +------------ arch/arm/mach-kirkwood/board-goflexnet.c | 34 ------- arch/arm/mach-kirkwood/board-guruplug.c | 33 ------- arch/arm/mach-kirkwood/board-ib62x0.c | 29 ------ arch/arm/mach-kirkwood/board-iconnect.c | 10 --- arch/arm/mach-kirkwood/board-iomega_ix2_200.c | 34 ------- arch/arm/mach-kirkwood/board-km_kirkwood.c | 44 ---------- arch/arm/mach-kirkwood/board-lsxl.c | 16 ---- arch/arm/mach-kirkwood/board-mplcec4.c | 14 --- arch/arm/mach-kirkwood/board-ns2.c | 35 -------- arch/arm/mach-kirkwood/board-openblocks_a6.c | 26 ------ arch/arm/mach-kirkwood/board-readynas.c | 6 --
Just a stupid note: With Thomas ongoing work to get mvebu-pcie driver in place and enabled for kirkwood, some boards setup files will also lose their pcie init routines, which may allow you to kill those additonal files soon. For instance 6bd98481ab34 (arm: kirkwood: NETGEAR ReadyNAS Duo v2 init PCIe via DT) currently sitting in jcooper/mvebu/pcie_kirkwood removes the PCIE init routine in board-readynas.c, and yours remove ge00 init. With both applied, the whole file can go away. AFAICT, this may be the case soon for: arch/arm/mach-kirkwood/board-iconnect.c (36e5722089) arch/arm/mach-kirkwood/board-mplcec4.c (9470fbfb8d) arch/arm/mach-kirkwood/board-nsa310.c (40fa8e5da2) arch/arm/mach-kirkwood/board-readynas.c (6bd98481ab) arch/arm/mach-kirkwood/board-ts219.c (259e234608) Anyway, thanks for this work Sebastian. Cheers, a+