Re: [PATCH] rcu: fix a race in hlist_nulls_for_each_entry_rcu macro
From: Eric Dumazet <hidden>
Date: 2013-05-21 13:37:34
Also in:
lkml
On Tue, 2013-05-21 at 05:09 -0700, Paul E. McKenney wrote:
quoted
-#define hlist_nulls_first_rcu(head) \ - (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) +#define hlist_nulls_first_rcu(head) \ + (*((struct hlist_nulls_node __rcu __force **) \ + &((volatile typeof(*head) *)head)->first))Why not use ACCESS_ONCE() or (better) rcu_dereference_raw() here?
+1 Very good catch Roman ! Thanks !