Re: [PATCH v3 net-next 1/4] net: implement support for low latency socket polling
flat view
From: Eric Dumazet <hidden>
Date: 2013-05-20 15:29:35
Also in:
lkml
On Mon, 2013-05-20 at 13:16 +0300, Eliezer Tamir wrote:
Adds a new ndo_ll_poll method and the code that supports and uses it. This method can be used by low latency applications to busy poll ethernet device queues directly from the socket code. The ip_low_latency_poll sysctl entry controls how many cycles to poll. Set to zero to disable.
This changelog lacks a lot of information, see below. Part of this information was in your 0/4 text, but it wont be included in the git tree.
Signed-off-by: Alexander Duyck <redacted> Signed-off-by: Jesse Brandeburg <redacted> Tested-by: Willem de Bruijn <willemb@google.com> Signed-off-by: Eliezer Tamir <redacted> ---
quoted hunk ↗ jump to hunk
+ +static inline void skb_mark_ll(struct sk_buff *skb, struct napi_struct *napi) +{ + skb->dev_ref = napi; +} + +static inline void sk_mark_ll(struct sock *sk, struct sk_buff *skb) +{ + sk->dev_ref = skb->dev_ref; +}
I do not see why it's safe to keep a pointer to a napi object without taking a reference, or something to prevent object being removed. Using a genid might be enough. (some counter incremented every time a napi is dismantled) Alternatively, use a napi_id instead of a pointer.