Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling
flat view
From: David Miller <davem@davemloft.net>
Date: 2013-05-20 07:54:50
Also in:
lkml
From: Eliezer Tamir <redacted> Date: Sun, 19 May 2013 13:25:33 +0300
quoted hunk ↗ jump to hunk
+#ifndef _LINUX_NET_LL_POLL_H +#define _LINUX_NET_LL_POLL_H +#ifdef CONFIG_INET_LL_RX_POLL
Please put an empty line before the final ifdef test here.
quoted hunk ↗ jump to hunk
+static inline void sk_mark_ll(struct sock *sk, struct sk_buff *skb) +{ + sk->dev_ref = skb->dev_ref;
^^^ One tab too many.
quoted hunk ↗ jump to hunk
+#else /* CONFIG_INET_LL_RX_FLUSH */ + +#define sk_valid_ll(sk) 0 +#define sk_poll_ll(sk, nonblock) do {} while (0) +#define skb_mark_ll(napi, skb) do {} while (0) +#define sk_mark_ll(sk, skb) do {} while (0)
Make these inline functions too, so that even if CONFIG_INET_LL_RX_POLL is disabled, the arguments and return values are still properly type checked.
quoted hunk ↗ jump to hunk
{ struct socket *sock; + unsigned int poll_result;
Please order local variable declarations from longest line to shortest line.
quoted hunk ↗ jump to hunk
+ !(poll_result & (POLLRDNORM | POLLERR | POLLRDHUP | POLLHUP))) { + + struct sock *sk = sock->sk;
Please remove the empty line before the variable declaration.