Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup

Petko Manolov [off-list ref] :

On Sat, 18 May 2013, Francois Romieu wrote:

quoted

quoted

From: Petko Manolov <petkan@nucleusys.com>

[...]

quoted

quoted

Moving constant and structure definitions out of rtl8150.c;

What's the point ?

The general logic of having .h files applies.

Which one ?
- share it through the kernel or with userspace
- personal choice .c split

I don't mind the later even if it does not exactly apply to a
WIP driver. I'd still avoid future copycat followers though.

[...]

quoted

quoted

 drivers/net/usb/rtl8150.c |  121 +----------------------------------
 1 file changed, 2 insertions(+), 119 deletions(-)

diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index a491d3a..7d1897b 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c

@@ -17,132 +17,15 @@
 #include <linux/usb.h>
 #include <asm/uaccess.h>
 
+#include "rtl8150.h"

It won't compile. You shouldn't do that.

It does compile.  Both inside and outside of the tree.

The rtl8150.h file is created in patch #2. This is patch #1.

So...

-- 
Ueimor