Thread (3 messages) 3 messages, 2 authors, 2013-05-19

Re: [PATCH 5/5] drivers: net: usb: rtl8150: bug fixing and cleanup

flat view

From: Petko Manolov <petkan@nucleusys.com>
Date: 2013-05-19 08:36:27
Also in: lkml

On Sat, 18 May 2013, Francois Romieu wrote:
Petko Manolov [off-list ref] :
[...]
quoted
@@ -681,16 +681,15 @@ static int rtl8150_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
 }
 
 static const struct net_device_ops rtl8150_netdev_ops = {
-	.ndo_open		= rtl8150_open,
-	.ndo_stop		= rtl8150_close,
-	.ndo_do_ioctl		= rtl8150_ioctl,
-	.ndo_start_xmit		= rtl8150_start_xmit,
-	.ndo_tx_timeout		= rtl8150_tx_timeout,
-	.ndo_set_rx_mode	= rtl8150_set_multicast,
-	.ndo_set_mac_address	= rtl8150_set_mac_address,
-
-	.ndo_change_mtu		= eth_change_mtu,
-	.ndo_validate_addr	= eth_validate_addr,
+	.ndo_open = rtl8150_open,
+	.ndo_stop = rtl8150_close,
+	.ndo_do_ioctl = rtl8150_ioctl,
+	.ndo_start_xmit = rtl8150_start_xmit,
+	.ndo_tx_timeout = rtl8150_tx_timeout,
+	.ndo_set_rx_mode = rtl8150_set_multicast,
+	.ndo_set_mac_address = rtl8150_set_mac_address,
+	.ndo_change_mtu	= eth_change_mtu,
+	.ndo_validate_addr = eth_validate_addr,
This is wrong.
I am inclined to agree with you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help