Thread (19 messages) 19 messages, 7 authors, 2013-05-29

Re: [PATCH net-next 4/4] igb: enable auxiliary PHC functions for the i210.

From: Ben Hutchings <hidden>
Date: 2013-05-29 20:32:15

On Wed, 2013-05-29 at 09:24 +0200, Richard Cochran wrote:
On Tue, May 28, 2013 at 09:12:02PM +0000, Keller, Jacob E wrote:
quoted
I think ethtool would be good, but what about using sysfs?
The problem I see with ethtool is that configuring GPIOs (and these
SDPs are really just GPIOs by a different name) is really the job of
the device tree. But of course, most x86 users of the i210 don't have
this option.

Also, using ethtool or sysfs is not really attractive for embedded
designs (let's not forget the poor embedded guys). I think we need to
have a way to specify the pin functions at (or before) kernel boot
time.  Barring DT and kconfig, using a module parameter is the only
way to accomplish this.
On x86 the correct place to put this information would presumably be an
ACPI table.  And if the BIOS doesn't provide it, there is
CONFIG_ACPI_CUSTOM_DSDT, though that may be a bit of a sledgehammer...

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help