Re: [PATCH] ip_vs_sh: fix build
From: Julian Anastasov <ja@ssi.bg>
Date: 2013-05-29 19:31:19
Also in:
lvs-devel
Hello, On Wed, 29 May 2013, Jan Beulich wrote:
quoted hunk ↗ jump to hunk
kfree_rcu() requires offsetof(..., rcu_head) < 4096, which can get violated with a sufficiently high CONFIG_IP_VS_SH_TAB_BITS. Signed-off-by: Jan Beulich <redacted> --- net/netfilter/ipvs/ip_vs_sh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)--- 3.10-rc3/net/netfilter/ipvs/ip_vs_sh.c +++ 3.10-rc3-ip_vs_sh-build/net/netfilter/ipvs/ip_vs_sh.c@@ -67,8 +67,8 @@ struct ip_vs_sh_bucket { #define IP_VS_SH_TAB_MASK (IP_VS_SH_TAB_SIZE - 1) struct ip_vs_sh_state { - struct ip_vs_sh_bucket buckets[IP_VS_SH_TAB_SIZE]; struct rcu_head rcu_head; + struct ip_vs_sh_bucket buckets[IP_VS_SH_TAB_SIZE];
Your fix reminds me about the same problem I noticed for LBLC (may be due to 10 bits) during development but forgot to check the other schedulers. The same solution is needed also for DH. OTOH, LBLC and LBLCR are correct. Do you prefer to provide similar fix for ip_vs_dh.c or I have to take care?
}; /*
Regards -- Julian Anastasov [off-list ref]