Thread (4 messages) 4 messages, 3 authors, 2013-05-16

Re: [PATCH] fix mv643xx_eth.c lockdep violation

flat view

From: David Miller <davem@davemloft.net>
Date: 2013-05-16 21:57:07

From: Russell King - ARM Linux <redacted>
Date: Thu, 16 May 2013 17:31:42 +0100
From: Russell King <redacted>
Subject: [PATCH] NET: mv643xx_eth: avoid lockdep dump on interface down

When the interface is shutdown, the mv643xx_eth driver hits the following
lockdep dump:
 ...
It seems that txq_reclaim() takes the netif tx lock:

        __netif_tx_lock(nq, smp_processor_id());

in a context outside of softirq context, and thus is susceptible to
deadlock should an interrupt occur.

Use __netif_tx_lock_bh()/__netif_tx_unlock_bh() instead.

Signed-off-by: Russell King <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help