Re: [PATCH V3] rtlwifi: rtl8192cu: Add new USB ID

On 05/16/2013 04:04 AM, Albert Pool wrote:

Op 15-05-13 22:34, Larry Finger schreef:

quoted

On 05/15/2013 03:23 PM, Sergei Shtylyov wrote:

quoted

Hello.

On 05/15/2013 07:03 PM, Larry Finger wrote:

quoted

From: Albert Pool <albertpool-2BgBnwcziRhmR6Xm/wNWPw@public.gmane.org>

This adds the USB ID of the On Networks N300MA, clone of Netgear WNA3100M.

Signed-off-by: Albert Pool <albertpool-2BgBnwcziRhmR6Xm/wNWPw@public.gmane.org>
Signed-off-by: Larry Finger <redacted>
Reported-by: Ana Rey <redacted>
---

John,

Please use this version. V2 still had some whitespace errors that I fixed.

Albert,

Please use scripts/checkpatch.pl to check the patch before you send it.

Thanks,

Larry
---

  drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c

b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
index 23d640a..18da6de 100644

--- a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c

@@ -349,6 +349,7 @@ static struct usb_device_id rtl8192c_usb_ids[] = {
      {RTL_USB_DEVICE(0x07aa, 0x0056, rtl92cu_hal_cfg)}, /*ATKK-Gemtek*/
      {RTL_USB_DEVICE(0x07b8, 0x8178, rtl92cu_hal_cfg)}, /*Funai -Abocom*/
      {RTL_USB_DEVICE(0x0846, 0x9021, rtl92cu_hal_cfg)}, /*Netgear-Sercomm*/
+    {RTL_USB_DEVICE(0x0846, 0xf001, rtl92cu_hal_cfg)}, /*On Netwrks N300MA*/

    "Networks", perhaps? Or does it hit 80 columns limit this way?

That is exactly the problem. I suppose I could allow one line to be 81
characters in length, but that would diminish the effectiveness of my
suggestion that checkpatch be used.

Thanks for noticing. At least someone is reading the patches.

Larry

So my patch v2 could not be used because the line was longer than 80 chars? (It
was 82, indeed)

Also the problems with bad signal were due to Ana Rey's AP. It's being fixed or
replaced today.

The long line was not the problem. If you run V2 through the checkpatch script, ypu will see that there were a number of <space><tab> sequences in the patch. Not only did they fail the check, but they also failed to apply on my source base.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html