Hello.

On 15-05-2013 4:51, Simon Horman wrote:

quoted

quoted

This change is motivated by the lager board which uses the r8a7790 SoC,
an R-Car SoC. For this board setting the RMIIMODE register is necessary.

quoted

quoted

This patch assumes this is valid for all R-Car SoCs.

quoted

    No, RMIIMODE register is not documented on R8A7778/9 SoCs and
this location is described as reserved. How's it called in R8A7790
manual, CXR15?

It appears to be undocumented in the R8A7790 I have.
Empirically it seems necessary for the lager/R8A7790.

    I wonder where you got the info then (and what writing 1 to this 
register means)...

To be honest I am entirely unsure of its relevance to other SoCs.

I wonder if a better approach would be to add a flag to platform
data rather than struct sh_eth_cpu_data. This would allow the register
to only be accessed on boards where it is known to be useful.

    Maybe...

quoted

quoted

Signed-off-by: Simon Horman <redacted>

WBR, Sergei