Re: [net-next PATCH 1/4] Revert "inet: limit length of fragment queue hash table bucket lists"
From: Jesper Dangaard Brouer <hidden>
Date: 2013-05-02 08:00:32
From: Jesper Dangaard Brouer <hidden>
Date: 2013-05-02 08:00:32
On Wed, 24 Apr 2013 17:00:30 -0700 Eric Dumazet [off-list ref] wrote:
On Wed, 2013-04-24 at 17:48 +0200, Jesper Dangaard Brouer wrote:quoted
This reverts commit 5a3da1fe9561828d0ca7eca664b16ec2b9bf0055. The problem with commit 5a3da1fe (inet: limit length of fragment queue hash table bucket lists) is that, once we hit the hash depth limit (of 128), the we *keep* the existing frag queues, not allowing new frag queues to be created. Thus, an attacker can effectivly block handling of fragments for 30 sec (as each frag queue have a timeout of 30 sec)I do not think its good to revert this patch. It was a step in right direction.
We need a revert, because we are too close to the merge window, and cannot complete the needed "steps" to make this patch safe, sorry. --Jesper