Re: [PATCH v5] net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W
From: Chen Gang <hidden>
Date: 2013-05-02 01:12:26
From: Chen Gang <hidden>
Date: 2013-05-02 01:12:26
On 2013年04月30日 00:29, David Miller wrote:
From: Chen Gang <redacted> Date: Thu, 25 Apr 2013 18:49:55 +0800quoted
Change MAC802154_CHAN_NONE from ~(u8)0 to 0xff, or the comparison in mac802154_wpan_xmit() for ``chan == MAC802154_CHAN_NONE'' will not succeed. This bug can be boiled down to ``u8 foo = 0xff; if (foo == ~(u8)0) [...] else [...]'' where the condition will always take the else branch. Signed-off-by: Chen Gang <redacted>Applied, thanks.
Thank you, too, and also thank the related members who provide your suggestions to this patch. -- Chen Gang Asianux Corporation