Thread (18 messages) 18 messages, 4 authors, 2013-04-30

Re: [PATCH net 1/3] unix/dgram: peek beyond 0-sized skbs

From: Eric Dumazet <hidden>
Date: 2013-04-25 18:49:01
Also in: lkml

On Thu, 2013-04-25 at 09:47 -0400, Benjamin Poirier wrote:
"77c1090 net: fix infinite loop in __skb_recv_datagram()" (v3.8) introduced a
regression:
After that commit, recv can no longer peek beyond a 0-sized skb in the queue.
__skb_recv_datagram() instead stops at the first skb with len == 0 and results
in the system call failing with -EFAULT via skb_copy_datagram_iovec().

if MSG_PEEK is not used, what happens here ?

It doesn't look right to me that we return -EFAULT if skb->len is 0,
EFAULT is reserved to faulting (ie reading/writing at least one byte)

How are we telling the user message had 0 byte, but its not EOF ?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help