Thread (12 messages) 12 messages, 4 authors, 2013-05-10

Re: [PATCH net-next 3/6] vxlan: fix byte order issues with NDA_PORT

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2013-04-29 23:40:20

On Mon, 29 Apr 2013 11:47:26 -0400
David Stevens [off-list ref] wrote:
        They were all in host order until your patch (though it looks like
I may have used __be16 instead of __u32 and it "worked" despite the
type error. I left it as 32 bits for netlink to be int-sized and not
have unintended promotions, not to mention because "vxlan_port" is 32bit,
and still is. I'm ok with switching them to network order and 16 bit,
but I think you should make "vxlan_port" the same byte
order and size as "remote_port" so the comparisons below don't require
byte-swapping at run-time, as the original code did not.
Module parameters need to be host order, and there isn't really a good
way to type them as 16 bit.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help