Re: [PATCH v2 5/7] usbnet: qmi_wwan: comments on suspend failure
From: Bjørn Mork <bjorn@mork.no>
Date: 2013-03-07 18:09:40
Also in:
linux-input
Possibly related (same subject, not in this thread)
- 2013-03-07 · [PATCH v2 5/7] usbnet: qmi_wwan: comments on suspend failure · Ming Lei <hidden>
Ming Lei [off-list ref] writes:
quoted hunk
If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch comments on the case and requires that both usbnet_suspend() and subdriver->suspend() MUST return 0 in system sleep context. Cc: Bjørn Mork <bjorn@mork.no> Signed-off-by: Ming Lei <redacted> --- drivers/net/usb/qmi_wwan.c | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index efb5c7c..8a60bdd 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c@@ -288,6 +288,11 @@ static int qmi_wwan_suspend(struct usb_interface *intf, pm_message_t message) struct qmi_wwan_state *info = (void *)&dev->data; int ret; + /* + * Both usbnet_suspend() and subdriver->suspend() MUST return 0 + * in system sleep context, otherwise, the resume callback has + * to recover device from previous suspend failure. + */ ret = usbnet_suspend(intf, message); if (ret < 0) goto err;
Acked-by: Bjørn Mork <bjorn@mork.no> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html