Re: [PATCH 0/2] Fix for mv643xx_eth built as module
From: Florian Fainelli <florian@openwrt.org>
Date: 2013-03-24 20:48:33
Also in:
linux-arm-kernel, linuxppc-dev
From: Florian Fainelli <florian@openwrt.org>
Date: 2013-03-24 20:48:33
Also in:
linux-arm-kernel, linuxppc-dev
Hello Simon, Le dimanche 24 mars 2013 21:33:58, Simon Baatz a écrit :
Recently [1], mv643xx_eth was changed to make use of mvmdio. However, this change introduces two problems when mvmdio and mv643xx_eth are built as modules: - mvmdio is not loaded automatically by udev - mv643xx_eth oopses when it can't find its PHY, i.e. when mvmdio is not yet loaded The first problem can be fixed easily by adding a module alias for the respective platform device. The proposed fix for the second problem uses EPROBE_DEFER as suggested by Thomas Petazzoni when the driver can't find its PHY. These patches apply on top of Florian Fainelli's patchset. They have been tested on Marvel Kirkwood non-DT.
Both fixes look good to me, thanks for fixing this! Acked-by: Florian Fainelli <florian@openwrt.org> -- Florian