Thanks, Thomas. But I didn't change any formatting. Just do the
substitution in place.
Should I re-format and re-send the patch?

On Thu, Mar 28, 2013 at 10:32 PM, Thomas Graf [off-list ref] wrote:

On 03/28/13 at 12:47am, Hong Zhiguo wrote:

quoted

diff --git a/net/ipv4/udp_diag.c b/net/ipv4/udp_diag.c
index 505b30a..467fb92 100644
--- a/net/ipv4/udp_diag.c
+++ b/net/ipv4/udp_diag.c

@@ -64,9 +64,9 @@ static int udp_dump_one(struct udp_table *tbl, struct sk_buff *in_skb,
              goto out;

      err = -ENOMEM;
-     rep = alloc_skb(NLMSG_SPACE((sizeof(struct inet_diag_msg) +
-                                  sizeof(struct inet_diag_meminfo) +
-                                  64)), GFP_KERNEL);
+     rep = nlmsg_new(sizeof(struct inet_diag_msg) +
+                                  sizeof(struct inet_diag_meminfo) + 64,
+                                  GFP_KERNEL);

This is formatted incorrectly, otherwise the patch looks good.

--
best regards
Hong Zhiguo