Re: [PATCH -next] GRE: Use strlcat() for size checking

From: Ben Hutchings <redacted>
Date: Wed, 27 Mar 2013 20:06:16 +0000

On Wed, 2013-03-27 at 19:48 +0100, Geert Uytterhoeven wrote:

quoted

On m68k, gcc tries to be smart and turns

    strncat(name, "%d", 2);

into a call to strlen() and a 16-bit store, causing a link failure,
as arch/m68k/include/asm/string.h provides strlen() using a macro:

    ERROR: "strlen" [net/ipv4/ip_tunnel.ko] undefined!

Perhaps you should fix the string library for m68k, then!

Right, this symbol really must be provided.

You cannot merely provide inlines.

The off-by-one error is seperate, but that should be fixed
differently.