Re: [Bug 55211] pci_disable_link_state PCIE_LINK_STATE_L0S no longer disables ASPM for ath5k
From: Yinghai Lu <yinghai@kernel.org>
Date: 2013-03-17 17:19:43
Also in:
linux-pci, lkml
On Sun, Mar 17, 2013 at 8:50 AM, [off-list ref] wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=55211
quoted hunk
--- Comment #9 from Roman Yepishev <roman.yepishev@gmail.com> 2013-03-17 15:50:23 ---Re-tested on two laptops - AOA150, ath5k device got ASPM disabled and on a Lenovo E420 I got ASPM disabled for iwlwifi-driven Intel Corporation Centrino Wireless-N 1000 [8086:0084]. Also I found http://article.gmane.org/gmane.linux.kernel.pci/20640 where a question was raised why pci_disable_link_state stopped doing anything for iwlwifi devices too.
good. Did you test first patch or second patch? Please test second patch only on affected platforms. old logic is quite strange, on boot path and hotplug path it have different aspm_disabled setting. as it could set aspm_disabled after pci root bus scanning. Second patch will not restore to old logic, and just remove not needed aspm_disabled checking for disabling path. So second patch is right fix, but it need more test. Thanks Yinghai
Attachments
- pci_acpi_osc_aspm_fix.patch [application/octet-stream] 3533 bytes · preview
- disable_aspm_remove_not_needed_check.patch [application/octet-stream] 3040 bytes · preview