Thread (6 messages) flat view 6 messages, 2 authors, 2013-03-07

Re: [PATCH net-next] vmxnet3: prevent div-by-zero panic when ring resizing uninitialized dev

From: David Miller <davem@davemloft.net>
Date: 2013-03-06 20:38:46
Also in: lkml

From: Bhavesh Davda <redacted>
Date: Wed,  6 Mar 2013 09:46:24 -0800
quoted hunk ↗ jump to hunk
Linux is free to call ethtool ops as soon as a netdev exists when probe
finishes. However, we only allocate vmxnet3 tx/rx queues and initialize the
rx_buf_per_pkt field in struct vmxnet3_adapter when the interface is
opened (UP).

Signed-off-by: Bhavesh Davda <redacted>
Signed-off-by: Shreyas N Bhatewara <redacted>
---
 drivers/net/vmxnet3/vmxnet3_drv.c     |    3 ++-
 drivers/net/vmxnet3/vmxnet3_ethtool.c |    6 ++++++
 drivers/net/vmxnet3/vmxnet3_int.h     |    4 ++--
 3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 4aad350..bfc5898 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -2922,7 +2922,7 @@ vmxnet3_probe_device(struct pci_dev *pdev,
 				    (int)num_online_cpus());
 	else
 #endif
-		num_rx_queues = 1;
+	num_rx_queues = 1;
Why are you un-indenting this else branch?  Please don't do that.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help