Re: [PATCH] n_gsm: Add Mutex to avoid race when net destroy
From: Jiri Slaby <hidden>
Date: 2013-03-01 09:10:26
Also in:
lkml
From: Jiri Slaby <hidden>
Date: 2013-03-01 09:10:26
Also in:
lkml
On 03/01/2013 09:51 AM, channing wrote:
quoted
It should stop the queue and schedule a workqueue to lock the mutex, unregister the hetdev and reset dlci->net. (Or maybe just call muxnet_put with the lock held.)Thanks, Jiri, you're right, I didn't notice that in validation because DEBUG_ATOMIC_SLEEP is not enabled in my platform :( Now I'm trying to work out the workqueue solution, when it finished I'll re-submit for review. What do you mean by "call muxnet_put with lock held"? do you mean to use spin lock instead of mutex?
No, I mean, in the newly added scheduled work, to lock the mutex and simply call muxnet_put. That should fix it, right? -- js suse labs