Re: [PATCH 2/3] netlink: Remove an unused pointer in netlink_skb_parms
From: Eric W. Biederman <hidden>
Date: 2013-03-21 06:36:24
net/ipv4/inet_diag.c: sk_user_ns(NETLINK_CB(in_skb).ssk), net/ipv4/inet_diag.c: sk_user_ns(NETLINK_CB(cb->skb).ssk), net/ipv4/inet_diag.c: sk_user_ns(NETLINK_CB(cb->skb).ssk), net/ipv4/udp_diag.c: sk_user_ns(NETLINK_CB(cb->skb).ssk), net/ipv4/udp_diag.c: sk_user_ns(NETLINK_CB(in_skb).ssk), net/netfilter/nfnetlink_log.c: sk_user_ns(NETLINK_CB(skb).ssk)); net/netlink/af_netlink.c: NETLINK_CB(skb).ssk = ssk; net/sched/cls_flow.c: sk_user_ns(NETLINK_CB(in_skb).ssk) != &init_user_ns) I count 8 uses. Eric
quoted hunk
diff --git a/include/linux/netlink.h b/include/linux/netlink.h index e0f746b..9ac1201 100644 --- a/include/linux/netlink.h +++ b/include/linux/netlink.h@@ -19,7 +19,6 @@ struct netlink_skb_parms { struct scm_creds creds; /* Skb credentials */ __u32 portid; __u32 dst_group; - struct sock *ssk; }; #define NETLINK_CB(skb) (*(struct netlink_skb_parms*)&((skb)->cb))