Re: igb driver triggers BUILD_BUG_ON on s390

On Mon, Mar 11, 2013 at 08:47:12AM -0700, Alexander Duyck wrote:

On 03/09/2013 02:00 AM, Heiko Carstens wrote:

quoted

git commit 74e238ead "igb: Support using build_skb in the case that
jumbo frames are disabled" added a BUILD_BUG_ON() to the igb drivers
which triggers on s390:

drivers/net/ethernet/intel/igb/igb_main.c:6231:2:
error: call to ‘__compiletime_assert_6235’ declared with attribute error:
  BUILD_BUG_ON failed: SKB_WITH_OVERHEAD(IGB_RX_BUFSZ) <
    (NET_SKB_PAD + NET_IP_ALIGN + IGB_TS_HDR_LEN + ETH_FRAME_LEN + ETH_FCS_LEN)

Any opinions?

A fix for this has already been submitted. As it turns out the
BUILD_BUG_ON is mostly redundant anyway since we used a similar
calculation to determine if we were going to enable the use of build_skb
per ring.

Ok, thanks!