Re: [PATCH 1/2] benet: Wait f/w POST until timeout

From: "Perla, Sathya" <redacted>
Date: Wed, 6 Mar 2013 04:45:03 +0000

quoted

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]

From: Gavin Shan <redacted>
Date: Mon,  4 Mar 2013 15:48:46 +0800

quoted

While PCI card faces EEH errors, reset (usually hot reset) is expected
to recover from the EEH errors. After EEH core finishes the reset, the
driver callback (be_eeh_reset) is called and wait the firmware to
complete POST successfully. The original code would return with error
once detecting failure during POST stage. That seems not enough.

The patch forces the driver (be_eeh_reset) to wait the firmware
completes POST until timeout, instead of returning error upon
detection POST failure immediately. Also, it would improve the
reliability of the EEH funtionality of the driver.

Signed-off-by: Gavin Shan <redacted>

I know that patch #2 of this series needs to be implemented differently, but this
patch seems fine.

So can I get an ACK from one of the benet driver folks?

Acked-by: Sathya Perla <redacted>

Applied, thanks for reviewing.