Re: [PATCH -next 1/1] net: skbuff: fix compile error in skb_panic()

From: Sedat Dilek <redacted>
Date: Wed, 13 Feb 2013 13:41:21 +0100

On Wed, Feb 13, 2013 at 12:20 PM, James Hogan [off-list ref] wrote:

quoted

I get the following build error on next-20130213 due to the following
commit:

commit f05de73bf82fbbc00265c06d12efb7273f7dc54a ("skbuff: create
skb_panic() function and its wrappers").

It adds an argument called panic to a function that uses the BUG() macro
which tries to call panic, but the argument masks the panic() function
declaration, resulting in the following error (gcc 4.2.4):

net/core/skbuff.c In function 'skb_panic':
net/core/skbuff.c +126 : error: called object 'panic' is not a function

[ CC linux-netdev ]

Hmm, with gcc-4.6.3 on Ubuntu/precise I don't see this... compiler-specific?

Kconfig option specific.

Applied, thanks James.