RE: [RFC PATCH 3/3] mlx4: Use default fdb handlers when not multifunction.

From: John Fastabend <redacted>
Date: Thu, Feb 28, 2013 at 6:27 AM
Subject: Re: [RFC PATCH 3/3] mlx4: Use default fdb handlers when not
multifunction.
To: Vlad Yasevich <redacted>, Amir Vadai <redacted>
Cc: netdev@vger.kernel.org, davem@davemloft.net


On 2/27/2013 9:46 AM, Vlad Yasevich wrote:

quoted

Allow the use of ndo_dflt_fdb_<add|del|dump> when the adapter is not
configured with virtual functins (!mlx4_is_mfunc()) This allows proper
IFF_UNICAST_FLT support and allows for additional handling by the
driver if needed.

CC: Amir Vadai <redacted>
Signed-off-by: Vlad Yasevich <redacted>
---
  drivers/net/ethernet/mellanox/mlx4/en_netdev.c |   12 +++---------
  1 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c

b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 5385474..5732025 100644

--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c

@@ -1934,7 +1934,7 @@ static int mlx4_en_fdb_add(struct ndmsg *ndm,

struct nlattr *tb[],

Amir are the default ops good enough here?

The default ops can be used instead of mlx4 fdb_add, fdb_delete, and fdb_dump.

Yan