Thread (14 messages) 14 messages, 5 authors, 2013-02-27

Re: [RFC PATCH] core: Add ioctls to control device unicast hw addresses

From: David Miller <davem@davemloft.net>
Date: 2013-02-26 20:03:13

From: Vlad Yasevich <redacted>
Date: Tue, 26 Feb 2013 14:44:22 -0500
David Miller wrote:
quoted
No new ioctls please, extend the netlink interfaces as necessary
instead.

Thanks.
So, something like below patch (compiled only) would be better in your opinion?
The one concern I have is that there is no way to probe for the availabilty
of this functionality, since netlink will just ignore unknown types and appear
to succeed.  With an ioctl it is clear if the support is present.

-- >8 --


[RFC PATCH] rtnetlink: Add support for adding/removing additional hw addresses.

Add an ability to add and remove HW addresses to the device
unicast and multicast address lists.  Right now, we only have
an ioctl() to manage the multicast addresses and there is no
way the manage the unicast list.

Signed-off-by: Vlad Yasevich <redacted>
This is a step in the right direction, and you're right that there is
a difficulty in detecting whether support exists or not.

I am so surprised that we've have ->set_rx_mode() support for multiple
unicast MAC addresses in so many drivers all this time, yet no way
outside of FDB to make use of it at all.

Anyways, as per the feature detection issue, we could create a new
RTM_* operation that returns a u32 feature flag mask.  It's just one
idea.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help