RE: [net-next 04/10] igb: Fix for sparse warning in igb_get_i2c_client

-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
On Behalf Of Ben Hutchings
Sent: Monday, February 11, 2013 9:06 AM
To: Kirsher, Jeffrey T; Wyborny, Carolyn
Cc: davem@davemloft.net; netdev@vger.kernel.org; gospo@redhat.com;
sassmann@redhat.com
Subject: Re: [net-next 04/10] igb: Fix for sparse warning in igb_get_i2c_client

On Fri, 2013-02-08 at 02:39 -0800, Jeff Kirsher wrote:

quoted

From: Carolyn Wyborny <redacted>

This patch changes definition of i2c_client in igb_get_i2c_client to
static to prevent sparse warning.

So, in order to fix the warning:

drivers/net/ethernet/intel/igb/igb_main.c:7611:19: warning: symbol
'igb_get_i2c_client' was not declared. Should it be static?

[..]

And this was not the warning I was trying to fix with the static change.  The sparse warning was "cast to 
restricted __le64."  Not sure why you are seeing that particular warning, but I will look for it in my next patch on this function.

Thanks,

Carolyn

Carolyn Wyborny 
Linux Development 
Networking Division 
Intel Corporation